chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Fix Repeat menu being disabled, change default

Browse source 
Default repeat mode should now be Repeat All, and the menu items should
now all function, fixed by removing a bunch of pointless attributes from
each affected menu item.

Fixes #371

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
This commit is contained in:
Christopher Snowhill 2023-07-29 00:55:14 -07:00
parent d606790ae3
commit 20531b2d04
No known key found for this signature in database
2 changed files with 2 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
Base.lproj/MainMenu.xib
View file

@ -1919,17 +1919,11 @@ CA
<menuItem title="Repeat" id="1740"> <menuItem title="Repeat" id="1740">
<menu key="submenu" title="Repeat" id="1741"> <menu key="submenu" title="Repeat" id="1741">
<items> <items>
<menuItem title="All" keyEquivalent="r" id="1742"> <menuItem title="All" state="on" keyEquivalent="r" id="1742">
<modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/> <modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
<connections> <connections>
<binding destination="218" name="value" keyPath="repeat" id="1760"> <binding destination="218" name="value" keyPath="repeat" id="1760">
<dictionary key="options"> <dictionary key="options">
<integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
<integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
<integer key="NSConditionallySetsEnabled" value="0"/>
<integer key="NSConditionallySetsHidden" value="0"/>
<integer key="NSRaisesForNotApplicableKeys" value="1"/>
<integer key="NSValidatesImmediately" value="0"/>
<string key="NSValueTransformerName">RepeatAllTransformer</string> <string key="NSValueTransformerName">RepeatAllTransformer</string>
</dictionary> </dictionary>
</binding> </binding>
@ -1939,8 +1933,6 @@ CA
<connections> <connections>
<binding destination="218" name="value" keyPath="repeat" id="2412"> <binding destination="218" name="value" keyPath="repeat" id="2412">
<dictionary key="options"> <dictionary key="options">
<bool key="NSAllowsEditingMultipleValuesSelection" value="NO"/>
<bool key="NSConditionallySetsEnabled" value="NO"/>
<string key="NSValueTransformerName">RepeatAlbumTransformer</string> <string key="NSValueTransformerName">RepeatAlbumTransformer</string>
</dictionary> </dictionary>
</binding> </binding>
@ -1950,12 +1942,6 @@ CA
<connections> <connections>
<binding destination="218" name="value" keyPath="repeat" id="1763"> <binding destination="218" name="value" keyPath="repeat" id="1763">
<dictionary key="options"> <dictionary key="options">
<integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
<integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
<integer key="NSConditionallySetsEnabled" value="0"/>
<integer key="NSConditionallySetsHidden" value="0"/>
<integer key="NSRaisesForNotApplicableKeys" value="1"/>
<integer key="NSValidatesImmediately" value="0"/>
<string key="NSValueTransformerName">RepeatOneTransformer</string> <string key="NSValueTransformerName">RepeatOneTransformer</string>
</dictionary> </dictionary>
</binding> </binding>
@ -1965,12 +1951,6 @@ CA
<connections> <connections>
<binding destination="218" name="value" keyPath="repeat" id="1767"> <binding destination="218" name="value" keyPath="repeat" id="1767">
<dictionary key="options"> <dictionary key="options">
<integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
<integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
<integer key="NSConditionallySetsEnabled" value="0"/>
<integer key="NSConditionallySetsHidden" value="0"/>
<integer key="NSRaisesForNotApplicableKeys" value="1"/>
<integer key="NSValidatesImmediately" value="0"/>
<string key="NSValueTransformerName">RepeatNoneTransformer</string> <string key="NSValueTransformerName">RepeatNoneTransformer</string>
</dictionary> </dictionary>
</binding> </binding>

2
Playlist/PlaylistController.m
View file

@ -98,7 +98,7 @@ static void *playlistControllerContext = &playlistControllerContext;
} }
- (void)initDefaults { - (void)initDefaults {
NSDictionary *defaultsDictionary = @{ @"repeat": @(RepeatModeNoRepeat), @"shuffle": @(ShuffleOff) }; NSDictionary *defaultsDictionary = @{ @"repeat": @(RepeatModeRepeatAll), @"shuffle": @(ShuffleOff) };
[[NSUserDefaults standardUserDefaults] registerDefaults:defaultsDictionary]; [[NSUserDefaults standardUserDefaults] registerDefaults:defaultsDictionary];
} }