From 587ccd6a0da3a085c4ce58c350b149765fdb237f Mon Sep 17 00:00:00 2001
From: Christopher Snowhill <kode54@gmail.com>
Date: Sat, 29 Jul 2023 00:55:14 -0700
Subject: [PATCH] Fix Repeat menu being disabled, change default

Default repeat mode should now be Repeat All, and the menu items should
now all function, fixed by removing a bunch of pointless attributes from
each affected menu item.

Fixes #371

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
---
 Base.lproj/MainMenu.xib       | 22 +---------------------
 Playlist/PlaylistController.m |  2 +-
 2 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/Base.lproj/MainMenu.xib b/Base.lproj/MainMenu.xib
index 4c363eee3..f9d2d0ca1 100644
--- a/Base.lproj/MainMenu.xib
+++ b/Base.lproj/MainMenu.xib
@@ -1875,17 +1875,11 @@ CA
                             <menuItem title="Repeat" id="1740">
                                 <menu key="submenu" title="Repeat" id="1741">
                                     <items>
-                                        <menuItem title="All" keyEquivalent="r" id="1742">
+                                        <menuItem title="All" state="on" keyEquivalent="r" id="1742">
                                             <modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
                                             <connections>
                                                 <binding destination="218" name="value" keyPath="repeat" id="1760">
                                                     <dictionary key="options">
-                                                        <integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
-                                                        <integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
-                                                        <integer key="NSConditionallySetsEnabled" value="0"/>
-                                                        <integer key="NSConditionallySetsHidden" value="0"/>
-                                                        <integer key="NSRaisesForNotApplicableKeys" value="1"/>
-                                                        <integer key="NSValidatesImmediately" value="0"/>
                                                         <string key="NSValueTransformerName">RepeatAllTransformer</string>
                                                     </dictionary>
                                                 </binding>
@@ -1895,8 +1889,6 @@ CA
                                             <connections>
                                                 <binding destination="218" name="value" keyPath="repeat" id="2412">
                                                     <dictionary key="options">
-                                                        <bool key="NSAllowsEditingMultipleValuesSelection" value="NO"/>
-                                                        <bool key="NSConditionallySetsEnabled" value="NO"/>
                                                         <string key="NSValueTransformerName">RepeatAlbumTransformer</string>
                                                     </dictionary>
                                                 </binding>
@@ -1906,12 +1898,6 @@ CA
                                             <connections>
                                                 <binding destination="218" name="value" keyPath="repeat" id="1763">
                                                     <dictionary key="options">
-                                                        <integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
-                                                        <integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
-                                                        <integer key="NSConditionallySetsEnabled" value="0"/>
-                                                        <integer key="NSConditionallySetsHidden" value="0"/>
-                                                        <integer key="NSRaisesForNotApplicableKeys" value="1"/>
-                                                        <integer key="NSValidatesImmediately" value="0"/>
                                                         <string key="NSValueTransformerName">RepeatOneTransformer</string>
                                                     </dictionary>
                                                 </binding>
@@ -1921,12 +1907,6 @@ CA
                                             <connections>
                                                 <binding destination="218" name="value" keyPath="repeat" id="1767">
                                                     <dictionary key="options">
-                                                        <integer key="NSAllowsEditingMultipleValuesSelection" value="0"/>
-                                                        <integer key="NSAlwaysPresentsApplicationModalAlerts" value="0"/>
-                                                        <integer key="NSConditionallySetsEnabled" value="0"/>
-                                                        <integer key="NSConditionallySetsHidden" value="0"/>
-                                                        <integer key="NSRaisesForNotApplicableKeys" value="1"/>
-                                                        <integer key="NSValidatesImmediately" value="0"/>
                                                         <string key="NSValueTransformerName">RepeatNoneTransformer</string>
                                                     </dictionary>
                                                 </binding>
diff --git a/Playlist/PlaylistController.m b/Playlist/PlaylistController.m
index 9306f0419..64f2df006 100644
--- a/Playlist/PlaylistController.m
+++ b/Playlist/PlaylistController.m
@@ -98,7 +98,7 @@ static void *playlistControllerContext = &playlistControllerContext;
 }
 
 - (void)initDefaults {
-	NSDictionary *defaultsDictionary = @{ @"repeat": @(RepeatModeNoRepeat), @"shuffle": @(ShuffleOff) };
+	NSDictionary *defaultsDictionary = @{ @"repeat": @(RepeatModeRepeatAll), @"shuffle": @(ShuffleOff) };
 
 	[[NSUserDefaults standardUserDefaults] registerDefaults:defaultsDictionary];
 }