From b03fdeaf7a1aaf7aa18e32c5959efc09149ac390 Mon Sep 17 00:00:00 2001 From: Christopher Snowhill Date: Sat, 11 Jun 2022 13:40:08 -0700 Subject: [PATCH] [File Tree Browser] Fix resource leak These two objects were or could have been leaked previously. Signed-off-by: Christopher Snowhill --- FileTree/PathNode.m | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/FileTree/PathNode.m b/FileTree/PathNode.m index 0f8509632..abfba3b0d 100644 --- a/FileTree/PathNode.m +++ b/FileTree/PathNode.m @@ -29,9 +29,14 @@ NSURL *resolveAliases(NSURL *url) { if(bookmarkRef) { Boolean isStale; CFURLRef urlRef = CFURLCreateByResolvingBookmarkData(kCFAllocatorDefault, bookmarkRef, kCFURLBookmarkResolutionWithSecurityScope, NULL, NULL, &isStale, &error); + CFRelease(bookmarkRef); - if(urlRef && !isStale) { - return (NSURL *)CFBridgingRelease(urlRef); + if(urlRef) { + if(!isStale) { + return (NSURL *)CFBridgingRelease(urlRef); + } else { + CFRelease(urlRef); + } } }