From e8775e17b083aabc2f41880dd03e38a8a4bfec7d Mon Sep 17 00:00:00 2001 From: Christopher Snowhill Date: Fri, 20 Jun 2025 19:33:36 -0700 Subject: [PATCH] Rubberband: Disable by default correctly The attempt to disable it by default only for new installs failed, as changing the default after restarting with consent achieved, resulted in the value changing as well, as is the way of changing defaults if the user has never changed them. Signed-off-by: Christopher Snowhill --- Application/PlaybackController.m | 2 +- Window/MainWindow.m | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Application/PlaybackController.m b/Application/PlaybackController.m index bd001438b..cd1c8b6f3 100644 --- a/Application/PlaybackController.m +++ b/Application/PlaybackController.m @@ -130,7 +130,7 @@ NSString *CogPlaybackDidStopNotificiation = @"CogPlaybackDidStopNotificiation"; @"enableHrtf": @(NO), @"enableHeadTracking": @(NO), @"enableHDCD": @(NO), - /*@"rubberbandEngine": @"faster",*/ + @"rubberbandEngine": @"disabled", @"rubberbandTransients": @"crisp", @"rubberbandDetector": @"compound", @"rubberbandPhase": @"laminar", diff --git a/Window/MainWindow.m b/Window/MainWindow.m index f3bd68d70..8ff21cc0f 100644 --- a/Window/MainWindow.m +++ b/Window/MainWindow.m @@ -19,8 +19,6 @@ void showSentryConsent(NSWindow *window) { BOOL askedConsent = [[NSUserDefaults standardUserDefaults] boolForKey:@"sentryAskedConsent"]; if(!askedConsent) { - [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"rubberbandEngine": @"disabled" }]; - [window orderFront:window]; NSAlert *alert = [[NSAlert alloc] init]; @@ -36,8 +34,6 @@ void showSentryConsent(NSWindow *window) { }]; [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"sentryAskedConsent"]; - } else { - [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"rubberbandEngine": @"faster" }]; } }