From f239784bf2e76e9b18744a6bfa7501c5e16cf3fc Mon Sep 17 00:00:00 2001 From: Christopher Snowhill Date: Sat, 15 Feb 2025 20:09:59 -0800 Subject: [PATCH] Bug Fix: Change how bad playlist setup is handled Reset to defaults if no columns are visible. Also log this situation in Firebase events, in case it becomes relevant. Signed-off-by: Christopher Snowhill --- Playlist/PlaylistView.m | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Playlist/PlaylistView.m b/Playlist/PlaylistView.m index fade50027..4b512e7a0 100644 --- a/Playlist/PlaylistView.m +++ b/Playlist/PlaylistView.m @@ -16,6 +16,8 @@ #import "Logging.h" +@import Firebase; + static NSString *playlistSavedColumnsID = @"Playlist Saved Columns v0"; @implementation PlaylistView @@ -152,14 +154,16 @@ static NSString *playlistSavedColumnsID = @"Playlist Saved Columns v0"; } if(visibleTableColumns == 0) { + // Reset to defaults + NSString *message = @"Reset playlist columns to default"; + DLog(@"%@", message); + [[FIRCrashlytics crashlytics] logWithFormat:@"%@", message]; for(NSTableColumn *col in columns) { - NSString *columnID = [col identifier]; - NSUInteger index = [defaultColumnList indexOfObject:columnID]; - if(index != NSNotFound) { - id column = [defaultColumns objectAtIndex:index]; - [col setWidth:[[column objectForKey:@"width"] unsignedIntegerValue]]; - [col setHidden:[[column objectForKey:@"hidden"] boolValue]]; - } + [self removeTableColumn:col]; + } + columns = oldColumns; + for(NSTableColumn *col in columns) { + [self addTableColumn:col]; } }