chris/Cog
2
1
Fork 0
Code Issues 64 Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

base: chris:31640b45d884541cefac5d1afdc35e685b239c55
Branches Tags
chris:main
chris:wip.tahoe
chris:sparkle
chris:emusc
chris:projectm
chris:update-vgmstream
chris:xcode15
chris:lastfm
chris:swiftingly
chris:CQTexperiment
chris:k54
chris:r516
..
compare: chris:c1ec5486881c58f4bac36dd34d91a485a6a51da7
Branches Tags
chris:wip.tahoe
chris:main
chris:sparkle
chris:emusc
chris:projectm
chris:update-vgmstream
chris:xcode15
chris:lastfm
chris:swiftingly
chris:CQTexperiment
chris:k54
chris:r516

3 commits
31640b45d8 ... c1ec548688

Author SHA1 Message Date
Christopher Snowhill
c1ec548688 Bug Fix: Disable buggy Selection Follows Playback 
Disable this by default, as it doesn't take output buffering into
account, so cursor moves up to 20 seconds ahead of what is actually
audible on the output device.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
 2025-06-11 19:03:01 -07:00
Christopher Snowhill
350f3a9e6e Bug Fix: Prevent track transition race condition 
A race on the source queue setter could cause a crash. Prevent that by
not attempting to set a nil input node.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
 2025-06-11 19:01:53 -07:00
Christopher Snowhill
d7dd775447 Bug Fix: Stop track fades from hanging on occasion 
Track fades could hang if fired in rapid succession. Now each fade will
be guaranteed to resume input feeding upon removing the current input to
the background fade-out queue.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
 2025-06-11 19:00:45 -07:00
3 changed files with 8 additions and 4 deletions
Show stats Expand all files Collapse all files

2
Application/AppController.m
View file

@ -706,7 +706,7 @@ static BOOL consentLastEnabled = NO;
[userDefaultsValuesDict setObject:@(44100) forKey:@"synthSampleRate"]; [userDefaultsValuesDict setObject:@(44100) forKey:@"synthSampleRate"];
[userDefaultsValuesDict setObject:@NO forKey:@"alwaysStopAfterCurrent"]; [userDefaultsValuesDict setObject:@NO forKey:@"alwaysStopAfterCurrent"];
[userDefaultsValuesDict setObject:@YES forKey:@"selectionFollowsPlayback"]; [userDefaultsValuesDict setObject:@NO forKey:@"selectionFollowsPlayback"];
// Register and sync defaults // Register and sync defaults
[[NSUserDefaults standardUserDefaults] registerDefaults:userDefaultsValuesDict]; [[NSUserDefaults standardUserDefaults] registerDefaults:userDefaultsValuesDict];

8
Audio/Chain/OutputNode.m
View file

@ -176,7 +176,9 @@
Node *finalNode = nil; Node *finalNode = nil;
if(rubberbandNode) { if(rubberbandNode) {
finalNode = [[controller bufferChain] finalNode]; finalNode = [[controller bufferChain] finalNode];
[rubberbandNode setPreviousNode:finalNode]; if(finalNode) {
[rubberbandNode setPreviousNode:finalNode];
}
} }
return !!finalNode; return !!finalNode;
@ -186,7 +188,9 @@
Node *finalNode = nil; Node *finalNode = nil;
if(rubberbandNode) { if(rubberbandNode) {
finalNode = [[controller bufferChain] finalNode]; finalNode = [[controller bufferChain] finalNode];
[rubberbandNode setPreviousNode:finalNode]; if(finalNode) {
[rubberbandNode setPreviousNode:finalNode];
}
} }
NSArray *DSPs = [self DSPs]; NSArray *DSPs = [self DSPs];

2
Audio/Output/OutputCoreAudio.m
View file

@ -982,6 +982,7 @@ current_device_listener(AudioObjectID inObjectID, UInt32 inNumberAddresses, cons
[fadedBuffers addObject:buffer]; [fadedBuffers addObject:buffer];
[fadedBuffersLock unlock]; [fadedBuffersLock unlock];
[outputLock unlock]; [outputLock unlock];
cutOffInput = NO;
} }
- (void)fadeIn { - (void)fadeIn {
@ -990,7 +991,6 @@ current_device_listener(AudioObjectID inObjectID, UInt32 inNumberAddresses, cons
fadeStep = ((fadeTarget - fadeLevel) / deviceFormat.mSampleRate) * (1000.0f / 125.0f); fadeStep = ((fadeTarget - fadeLevel) / deviceFormat.mSampleRate) * (1000.0f / 125.0f);
fading = YES; fading = YES;
faded = NO; faded = NO;
cutOffInput = NO;
} }
@end @end