WIP: Attempt to actually use the custom icons

Signed-off-by: Christopher Snowhill <kode54@gmail.com>

Audio/AudioPlayer.m

@@ -79,9 +79,7 @@
 	}
 	if(!output) {
 		output = [[OutputNode alloc] initWithController:self previous:nil];
-		if(![output setupWithInterval:resumeInterval]) {
-			return;
-		}
+		[output setupWithInterval:resumeInterval];
 	}
 	[output setVolume:volume];
 	@synchronized(chainQueue) {

Audio/Chain/OutputNode.h

@@ -45,8 +45,8 @@
 
 - (double)secondsBuffered;
 
-- (BOOL)setup;
-- (BOOL)setupWithInterval:(BOOL)resumeInterval;
+- (void)setup;
+- (void)setupWithInterval:(BOOL)resumeInterval;
 - (void)process;
 - (void)close;
 - (void)seek:(double)time;

Audio/Chain/OutputNode.m

@@ -33,11 +33,11 @@
 	VisualizationNode *visualizationNode;
 }
 
-- (BOOL)setup {
-	return [self setupWithInterval:NO];
+- (void)setup {
+	[self setupWithInterval:NO];
 }
 
-- (BOOL)setupWithInterval:(BOOL)resumeInterval {
+- (void)setupWithInterval:(BOOL)resumeInterval {
 	if(!resumeInterval) {
 		amountPlayed = 0.0;
 		amountPlayedInterval = 0.0;
@@ -49,26 +49,23 @@
 
 	output = [[OutputCoreAudio alloc] initWithController:self];
 
-	if(![output setup]) {
-		output = nil;
-		return NO;
-	}
+	[output setup];
 
 	if(!DSPsLaunched) {
 		rubberbandNode = [[DSPRubberbandNode alloc] initWithController:self previous:nil latency:0.1];
-		if(!rubberbandNode) return NO;
+		if(!rubberbandNode) return;
 		fsurroundNode = [[DSPFSurroundNode alloc] initWithController:self previous:rubberbandNode latency:0.03];
-		if(!fsurroundNode) return NO;
+		if(!fsurroundNode) return;
 		equalizerNode = [[DSPEqualizerNode alloc] initWithController:self previous:fsurroundNode latency:0.03];
-		if(!equalizerNode) return NO;
+		if(!equalizerNode) return;
 		hrtfNode = [[DSPHRTFNode alloc] initWithController:self previous:equalizerNode latency:0.03];
-		if(!hrtfNode) return NO;
+		if(!hrtfNode) return;
 		downmixNode = [[DSPDownmixNode alloc] initWithController:self previous:hrtfNode latency:0.03];
-		if(!downmixNode) return NO;
+		if(!downmixNode) return;
 
 		// Approximately double the chunk size for Vis at 44100Hz
 		visualizationNode = [[VisualizationNode alloc] initWithController:self previous:downmixNode latency:8192.0 / 44100.0];
-		if(!visualizationNode) return NO;
+		if(!visualizationNode) return;
 
 		[self setPreviousNode:visualizationNode];
 
@@ -78,8 +75,6 @@
 
 		previousInput = nil;
 	}
-
-	return YES;
 }
 
 - (void)seek:(double)time {

Audio/Output/OutputCoreAudio.m

@@ -223,12 +223,8 @@ current_device_listener(AudioObjectID inObjectID, UInt32 inNumberAddresses, cons
 	while(!stopping) {
 		@autoreleasepool {
 			if(outputdevicechanged) {
-				if([self updateDeviceFormat]) {
+				[self updateDeviceFormat];
 				outputdevicechanged = NO;
-				} else {
-					usleep(2000);
-					continue;
-				}
 			}
 
 			if([outputController shouldReset]) {
@@ -478,9 +474,6 @@ current_device_listener(AudioObjectID inObjectID, UInt32 inNumberAddresses, cons
 
 - (BOOL)updateDeviceFormat {
 	AVAudioFormat *format = _au.outputBusses[0].format;
-	if(!format) {
-		return NO;
-	}
 
 	if(!_deviceFormat || ![_deviceFormat isEqual:format]) {
 		NSError *err;
@@ -812,9 +805,7 @@ current_device_listener(AudioObjectID inObjectID, UInt32 inNumberAddresses, cons
 
 		[_au allocateRenderResourcesAndReturnError:&err];
 
-		if(![self updateDeviceFormat]) {
-			return NO;
-		}
+		[self updateDeviceFormat];
 
 		visController = [VisualizationController sharedController];