chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Adding FLAC files causes hang #149

New issue
Closed
opened 2021-05-07 06:40:37 -04:00 by JanX2 · 7 comments
JanX2 commented 2021-05-07 06:40:37 -04:00 (Migrated from github.com)
Copy link

Describe
Adding FLAC files causes hang.

To Reproduce
Steps to reproduce the behavior:

  1. Drag FLAC files (or a folder hierarchy containing them) onto the playlist.
  2. Cog hangs.
  3. Log repeatedly shows entries like this:
    2021-05-07 12:34:59.921071+0200 Cog[47253:1966326] -[CoreAudioDecoder close] (line 83) Error closing ExtAudioFile
    2021-05-07 12:34:59.921124+0200 Cog[47253:1966326] -[CoreAudioDecoder close] (line 88) Error closing AudioFile

Expected behavior
Progress sheet or adding files in the background. Alternatively, very short beach ball.

Version information:

  • macOS version: 10.15.7
  • Cog version: Current HEAD: c5ac867

Additional context
I have only tried adding files from my server.

**Describe** Adding FLAC files causes hang. **To Reproduce** Steps to reproduce the behavior: 1. Drag FLAC files (or a folder hierarchy containing them) onto the playlist. 2. Cog hangs. 3. Log repeatedly shows entries like this: 2021-05-07 12:34:59.921071+0200 Cog[47253:1966326] -[CoreAudioDecoder close] (line 83) Error closing ExtAudioFile 2021-05-07 12:34:59.921124+0200 Cog[47253:1966326] -[CoreAudioDecoder close] (line 88) Error closing AudioFile **Expected behavior** Progress sheet or adding files in the background. Alternatively, very short beach ball. **Version information:** - macOS version: 10.15.7 - Cog version: Current HEAD: c5ac867 **Additional context** I have only tried adding files from my server.
kode54 commented 2021-05-07 18:08:04 -04:00 (Migrated from github.com)
Copy link

Huh, it shouldn't be logging that when closing on remote files.

Huh, it shouldn't be logging that when closing on remote files.
kode54 commented 2021-05-07 18:35:49 -04:00 (Migrated from github.com)
Copy link

Please email me one such FLAC file, and post here what method you are using to access the file. HTTP/S, SMB share, etc.

Please email me one such FLAC file, and post here what method you are using to access the file. HTTP/S, SMB share, etc.
kode54 commented 2021-05-07 20:20:40 -04:00 (Migrated from github.com)
Copy link

I brought back background loading for all but the first track of an operation, with queued loading for up to 8 tracks at once.

I brought back background loading for all but the first track of an operation, with queued loading for up to 8 tracks at once.
JanX2 commented 2021-05-08 05:07:13 -04:00 (Migrated from github.com)
Copy link

Thanks @kode54. I will test this soon. Do you still require a sample file? I’m accusing the server (Mac OS X 10.12 Server) via SMB. The data is on a disk attached via USB 2.0, but debugging instrumentation shows that bandwidth at least doesn’t appear to be the issue.

Thanks @kode54. I will test this soon. Do you still require a sample file? I’m accusing the server (Mac OS X 10.12 Server) via SMB. The data is on a disk attached via USB 2.0, but debugging instrumentation shows that bandwidth at least doesn’t appear to be the issue.
kode54 commented 2021-05-08 17:26:11 -04:00 (Migrated from github.com)
Copy link

Prior to the latest update, it would sequentially fetch the properties and metadata for all tracks added to the player. Now it will fetch the first one in the foreground so it can start playing immediately, while it fetches the rest in the background, up to 8 at a time. VGMStream still uses a properties and metadata cache, because its file access API is kind of inefficient, and would end up eating a lot of file handles during the process.

Prior to the latest update, it would sequentially fetch the properties and metadata for all tracks added to the player. Now it will fetch the first one in the foreground so it can start playing immediately, while it fetches the rest in the background, up to 8 at a time. VGMStream still uses a properties and metadata cache, because its file access API is kind of inefficient, and would end up eating a lot of file handles during the process.
kode54 commented 2022-02-10 05:37:10 -03:00 (Migrated from github.com)
Copy link

Please test again.

Please test again.
kode54 commented 2022-02-20 07:01:07 -03:00 (Migrated from github.com)
Copy link

Closing until OP responds. @JanX2 Please test again.

Closing until OP responds. @JanX2 Please test again.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
sparkle
emusc
projectm
update-vgmstream
xcode15
lastfm
swiftingly
CQTexperiment
k54
r516
Labels
Clear labels   
2230

   
2243

   
App version

   
Apple OS errata

Errata affecting old macOS releases

  
Apple SDK

   
bug

   
bugsnag

   
build

improve or fix project building

  
dlt

To be deleted

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chris/Cog#149
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?