Toolbar customization broken by 2170 if defaults are dragged onto the toolbar #266
Labels
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: chris/Cog#266
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe
As of tag 2170, the first version to introduce the Metal visualizer, whether or not it successfully initializes, the toolbar will no longer be configurable if the defaults are dragged onto the toolbar from the customize pane.
To Reproduce (delete if not applicable)
Steps to reproduce the behavior:
Expected behavior
Controls should still be removable or addable.
Version information:*
Additional context
This bug only affects macOS High Sierra, so it should probably be safe to close it as WONTFIX.
This appears to affect Mojave as well. No idea if it affects Catalina or Big Sur, but it doesn't affect Monterey or Ventura beta.
Unable to customize toolbar in Mojave (or Catalina) EXCEPT for dragging in default. Dragging default doesn't break customization, it's just the only action customization will allow.
I can open any versions of Cog PRE-v2170 and customize the toolbar as expected. I can then reopen Cog post-v2170 and toolbar changes which were made in earlier versions are recognized and honored.
In post-2170, I am unable to add or remove any item from toolbar, except if toolbar is not already set to default. In that case, I am able to drag in defaults - then unable to make any other changes without reverting to Pre-2170. Dragging default into window is not the thing that breaks customization - it's just the only action allowed.
I have just confirmed the same issue appears in Catalina running a Mac Mini (i7).
EDIT: Newest versions of Cog allow some customization. I can add items not already in default, but then can't remove them except by reverting to default. "Space" does not seem to be affected. I am able to add or remove 'space'.
This may be fixed by
7c8a270ed2, which may apparently affect newer SDK versions, which I may have switched to back around 2170? I was still using Xcode 13 around then, but maybe a newer version at that point. I've also since switched to working with Xcode 14 beta on Ventura beta, which seems to be mostly fine for now.Let me know how 2255-g90b83f8f handles it, once I've uploaded it.
This is a bug in the Xcode 13.4, 13.4.1, and 14.0 beta compilers. 13.3.1 is the last version to work properly. 13.3.1 requires Monterey or Big Sur to work.
version 2260 fixes this issue for me.
Confirmed to be working in Catalina and Mojave.
Thanks!
Version 2260 was built with Xcode 13.3.1 on macOS Monterey. That is how I have to build it until this issue is resolved by Apple.
Incidentally, the bug has been confirmed to also affect Monterey when built with Xcode 14.0 beta. So this bug continues to be a problem for all stable OS users.
I've discovered that 2260 and after, "Spectrum" can be added to toolbar only by adding the default toolbar. It can't be added by dragging 'spectrum' individually, and its icon remains blank in the customization window. However, the icon will appear normally in the toolbar if default set is dragged in. I can individually drag Spectrum icon out of the toolbar once default set is added, but can only get it back by adding it as part of the whole default toolbar.
This is a minor issue at this point, since I can get full customization by dragging in default set and customizing from there.
Enclosed screenshot of customization window showing blank "spectrum" icon.
I can't reproduce this with 2268-g9d558a89 on High Sierra. I don't have Catalina to test.
Verified that this issue does occur still with the spectrum button, but only on Mojave and Catalina, not High Sierra or Monterey, and presumably not Big Sur. Doesn't seem to affect Ventura.
I just discovered that in the customize toolbar window, if I put my cursor over the blank space above the "spectrum" text where the Icon should normally appear, and just drag the blank and empty space into the toolbar - as if there were an icon, Spectrum will add normally and show in the toolbar as expected. (see screen capture)
https://user-images.githubusercontent.com/73963913/174115272-a6d6627f-0bd6-4003-854e-8e610beb1f61.mp4
.
All of above issues resolved as of version 2318.
Please verify whether this has reoccurred with the web version, and compare with the App Store version. Follow the pinned issue if you are migrating from a non-Sandboxed version.
Has anyone noticed this problem still occurring? There are several versions in the current history where I was using Xcode 14 beta 2 for the self distribution version.