Opus format files no longer show tags when using CoreAudioDecoder #403

New issue

Open

opened 2024-10-08 00:19:47 -03:00 by faxx1080 · 1 comment

faxx1080 commented

2024-10-08 00:19:47 -03:00

(Migrated from github.com)

Describe
I noticed file tags (Artist, album, etc) don't show up with opus files anymore.
I tracked this down to PluginController.m:audioDecoderForSource and metadataForURL.

This code restores old behavior:

          if(  ([[_decoders objectAtIndex:i] isEqualToString:@"CoreAudioDecoder"])
             && ( [ext isEqual:@"opus"] || [ext isEqual:@"OPUS"] )   ) {
            DLog(@"PATCH: Removing CoreAudioDecoder for opus - this is for playing not metadata");
            [_decoders removeObjectAtIndex:i];

To Reproduce (delete if not applicable)
Steps to reproduce the behavior:

Add an opus file
Tags don't show up.

Expected behavior
Tags should show up.

Version information:*

macOS version: 15.0.1
Cog version: Version 2859 (2859-g8498bba88)

Additional context
I believe a recent macOS update (14.6) may have added CoreAudioDecoder for opus files, causing this to happen.

**Describe** I noticed file tags (Artist, album, etc) don't show up with opus files anymore. I tracked this down to PluginController.m:audioDecoderForSource and metadataForURL. This code restores old behavior: ``` if( ([[_decoders objectAtIndex:i] isEqualToString:@"CoreAudioDecoder"]) && ( [ext isEqual:@"opus"] || [ext isEqual:@"OPUS"] ) ) { DLog(@"PATCH: Removing CoreAudioDecoder for opus - this is for playing not metadata"); [_decoders removeObjectAtIndex:i]; ``` **To Reproduce** (delete if not applicable) Steps to reproduce the behavior: 1. Add an opus file 2. Tags don't show up. **Expected behavior** Tags should show up. **Version information:*** - macOS version: 15.0.1 - Cog version: Version 2859 (2859-g8498bba88) **Additional context** I believe a recent macOS update (14.6) may have added CoreAudioDecoder for opus files, causing this to happen.

kode54 commented

2024-10-08 08:55:31 -03:00

(Migrated from github.com)

Feel free to adjust this to a lower priority instead:

https://github.com/losnoco/Cog/blob/main/Plugins/CoreAudio/CoreAudioDecoder.m#L378

Feel free to adjust this to a lower priority instead: https://github.com/losnoco/Cog/blob/main/Plugins/CoreAudio/CoreAudioDecoder.m#L378