chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Reveal shortcut mod #52

Merged
JanX2 merged 2 commits from reveal-shortcut-mod into master 2020-08-14 19:13:02 -04:00
Conversation 5 Commits 2 Files changed 1 +7 -7
JanX2 commented 2020-07-18 07:10:32 -04:00 (Migrated from github.com)
Copy link

Now that I finally managed to build and test the current HEAD commit, i want to propose these changes.

The goal is to swap the keyboard shortcuts for "Playlist > Repeat > Toggle" (now ⌘R) and "Playlist > Show in Finder" (now ⇧⌘R). This is done to get them in line with iTunes and muscle memory for some users (including me). :D

Now that I finally managed to build and test the current HEAD commit, i want to propose these changes. The goal is to swap the keyboard shortcuts for "Playlist > Repeat > Toggle" (now ⌘R) and "Playlist > Show in Finder" (now ⇧⌘R). This is done to get them in line with iTunes and muscle memory for some users (including me). :D
ghost commented 2020-07-18 09:37:51 -04:00 (Migrated from github.com)
Copy link

You know that you can customize application shortcuts on the Keyboard System Preferences, right? I've been using ⌘R to toggle Repeat and ⌘S to toggle Shuffle for a long time.

You know that you can customize application shortcuts on the Keyboard System Preferences, right? I've been using <kbd>⌘R</kbd> to toggle Repeat and <kbd>⌘S</kbd> to toggle Shuffle for a long time.
JanX2 commented 2020-07-26 07:40:16 -04:00 (Migrated from github.com)
Copy link

Yes. But I considered this important as a default. I use several machines and OS installations. Customizing would require setting this on every install.

Yes. But I considered this important as a default. I use several machines and OS installations. Customizing would require setting this on every install.
JanX2 commented 2020-08-14 06:31:32 -04:00 (Migrated from github.com)
Copy link

@kode54
Can I persuade you to merge this, or do you consider these changes not worthwhile?

@kode54 Can I persuade you to merge this, or do you consider these changes not worthwhile?
kode54 commented 2020-08-14 19:13:19 -04:00 (Migrated from github.com)
Copy link

Sure, but I'm not on a Mac lately, so don't expect any binaries any time soon.

Sure, but I'm not on a Mac lately, so don't expect any binaries any time soon.
JanX2 commented 2020-08-16 15:09:01 -04:00 (Migrated from github.com)
Copy link

Thank you! No worries. I usually build them myself!

Thank you! No worries. I usually build them myself!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
2230

   
2243

   
App version

   
Apple OS errata

Errata affecting old macOS releases

  
Apple SDK

   
bug

   
bugsnag

   
build

improve or fix project building

  
dlt

To be deleted

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chris/Cog#52
No description provided.
Delete branch "reveal-shortcut-mod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?