Fix apple silicon flac crash #56

Merged

dleehr merged 3 commits from fix-apple-silicon-flac-crash into ohsir

2020-11-23 19:20:24 -03:00

dleehr commented

2020-11-23 19:06:58 -03:00

(Migrated from github.com)

Fixes FLAC playback crash on Apple Silicon

Avoid creating an NSDictionary with NULL context object (https://github.com/kode54/Cog/blob/master/Audio/Chain/InputNode.m#L81 passes NULL as context, so this must be handled in NSDictionary creation
When calling addObserver, downgrade options from NSNumber * to NSKeyValueObservingOptions (aka NSUInteger)

Not sure why this would be specific to Apple Silicon, but it did fix FLAC playback on my DTK. Doesn't seem related to libFLAC on ARM.

This reverts last night's changes to FlacDecoder.m. Even if you continue using Core Audio for FLAC Decoding, this change should help with formats that use CogPluginMulti.m ¯\(ツ)/¯.

Fixes FLAC playback crash on Apple Silicon - Avoid creating an NSDictionary with NULL context object (https://github.com/kode54/Cog/blob/master/Audio/Chain/InputNode.m#L81 passes NULL as context, so this must be handled in NSDictionary creation - When calling `addObserver`, downgrade `options` from `NSNumber *` to `NSKeyValueObservingOptions` (aka `NSUInteger`) Not sure why this would be specific to Apple Silicon, but it did fix FLAC playback on my DTK. Doesn't seem related to libFLAC on ARM. This reverts last night's changes to `FlacDecoder.m`. Even if you continue using Core Audio for FLAC Decoding, this change should help with formats that use `CogPluginMulti.m` ¯\\_(ツ)_/¯.

kode54 commented

2020-11-23 19:20:30 -03:00

(Migrated from github.com)

Thanks!