chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Show album art with UserNotification api. #61

Merged
nevack merged 3 commits from nevack/notifications into master 2021-01-07 04:22:15 -03:00
Conversation 4 Commits 3 Files changed 4 +47 -4
nevack commented 2020-12-26 10:46:20 -03:00 (Migrated from github.com)
Copy link

Also hide no-op iTunes Style option.

Also hide no-op iTunes Style option.
kode54 commented 2021-01-07 01:52:57 -03:00 (Migrated from github.com)
Copy link

Quick question regarding this: Will there be a race condition for the temp file? Does it really need to be a file and not a memory object? I can apply this if you're sure it's ready.

Quick question regarding this: Will there be a race condition for the temp file? Does it really need to be a file and not a memory object? I can apply this if you're sure it's ready.
nevack (Migrated from github.com) reviewed 2021-01-07 02:47:32 -03:00
nevack (Migrated from github.com) left a comment
Copy link

Quick question regarding this: Will there be a race condition for the temp file? Does it really need to be a file and not a memory object? I can apply this if you're sure it's ready.

I don't know a way to make URL to NSData.

Used this tutorial https://nshipster.com/temporary-files/#creating-a-temporary-file

> Quick question regarding this: Will there be a race condition for the temp file? Does it really need to be a file and not a memory object? I can apply this if you're sure it's ready. I don't know a way to make URL to NSData. Used this tutorial https://nshipster.com/temporary-files/#creating-a-temporary-file
Application/PlaybackEventController.m
nevack (Migrated from github.com) commented 2021-01-03 19:43:27 -03:00
Copy link

@kode54 Can you suggest a better way to do this?
We need to supply URL to local file as per UNNotificationAttachment documentation.

@kode54 Can you suggest a better way to do this? We need to supply URL to local file as per UNNotificationAttachment documentation.
Preferences/General/Base.lproj/Preferences.xib
@ -409,3 +409,4 @@
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
<buttonCell key="cell" type="check" title="Enable notifications" bezelStyle="regularSquare" imagePosition="left" alignment="left" inset="2" id="hqT-nY-NoU">
<behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/>
<font key="font" metaFont="system"/>
nevack (Migrated from github.com) commented 2021-01-03 19:47:38 -03:00
Copy link

image

![image](https://user-images.githubusercontent.com/8330119/103490726-d097bf00-4e2e-11eb-8e99-262332b4cc17.png)
nevack commented 2021-01-07 02:51:16 -03:00 (Migrated from github.com)
Copy link

PS. I think it's better to save Album art in Cog's Cache folder instead of storing bytes in xml.

PS. I think it's better to save Album art in Cog's Cache folder instead of storing bytes in xml.
kode54 commented 2021-01-07 02:56:25 -03:00 (Migrated from github.com)
Copy link

PS. I think it's better to save Album art in Cog's Cache folder instead of storing bytes in xml.

You're welcome to help make that possible, too. I'm thinking maybe hash filenames, similar to what I'm already using for the reference keys in the xml. Meh, I probably should have done this in the first place.

I'm also looking to some day make the whole thing sandbox-able. The whole main barrier is keeping a minimal amount of NSBookmark handles around in the saved data so permission to all the local tracks in the playlist persists. Perhaps permission to the entire local files' folders, too, since I also had some person ask if I could make it possible to scan for and add entire albums from folders just from adding one or more tracks. That sounds a mite complicated, though.

> PS. I think it's better to save Album art in Cog's Cache folder instead of storing bytes in xml. You're welcome to help make that possible, too. I'm thinking maybe hash filenames, similar to what I'm already using for the reference keys in the xml. Meh, I probably should have done this in the first place. I'm also looking to some day make the whole thing sandbox-able. The whole main barrier is keeping a minimal amount of NSBookmark handles around in the saved data so permission to all the local tracks in the playlist persists. Perhaps permission to the entire local files' folders, too, since I also had some person ask if I could make it possible to scan for and add entire albums from folders just from adding one or more tracks. That sounds a mite complicated, though.
kode54 (Migrated from github.com) reviewed 2021-01-07 02:58:32 -03:00
Application/PlaybackEventController.m
kode54 (Migrated from github.com) commented 2021-01-07 02:58:32 -03:00
Copy link

Nope. And I can't suggest using a unique name, either, because then it's on us to wipe out the old files when placing a new file. Maybe using a specific temp file name pattern, and wiping them all on startup, exit, and before placing a new file, but still using a unique name, so that old requests pull the missing file, while new are guaranteed to always get the newly generated file. Or something.

Nope. And I can't suggest using a unique name, either, because then it's on us to wipe out the old files when placing a new file. Maybe using a specific temp file name pattern, and wiping them all on startup, exit, and before placing a new file, but still using a unique name, so that old requests pull the missing file, while new are guaranteed to always get the newly generated file. Or something.
kode54 (Migrated from github.com) reviewed 2021-01-07 02:59:21 -03:00
Preferences/General/Base.lproj/Preferences.xib
@ -409,3 +409,4 @@
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
<buttonCell key="cell" type="check" title="Enable notifications" bezelStyle="regularSquare" imagePosition="left" alignment="left" inset="2" id="hqT-nY-NoU">
<behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/>
<font key="font" metaFont="system"/>
kode54 (Migrated from github.com) commented 2021-01-07 02:59:21 -03:00
Copy link

Also, I'm open to suggestions to replace the icon and category. It should be a "notifications" category or perhaps "toasts" or something, and it needs an appropriate icon.

Also, I'm open to suggestions to replace the icon and category. It should be a "notifications" category or perhaps "toasts" or something, and it needs an appropriate icon.
kode54 (Migrated from github.com) reviewed 2021-01-07 03:01:06 -03:00
Application/PlaybackEventController.m
kode54 (Migrated from github.com) commented 2021-01-07 03:01:06 -03:00
Copy link

Oh, it already produces a unique name. Huh, sorry I didn't notice that sooner.

Oh, it already produces a unique name. Huh, sorry I didn't notice that sooner.
nevack commented 2021-01-07 03:23:44 -03:00 (Migrated from github.com)
Copy link

I'll update preference pane icons to SF Symbols for macOS 11.0+ and rename Growl to Notifications in next PR

I'll update preference pane icons to SF Symbols for macOS 11.0+ and rename Growl to Notifications in next PR
kode54 (Migrated from github.com) approved these changes 2021-01-07 04:22:09 -03:00
kode54 (Migrated from github.com) left a comment
Copy link

Okay, looks good.

Okay, looks good.
Sign in to join this conversation.
Reviewers
No reviewers
kode54
Labels
Clear labels   
2230

   
2243

   
App version

   
Apple OS errata

Errata affecting old macOS releases

  
Apple SDK

   
bug

   
bugsnag

   
build

improve or fix project building

  
dlt

To be deleted

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chris/Cog#61
No description provided.
Delete branch "nevack/notifications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?