Update volume slider to use NSPopover. #67

Merged

nevack merged 1 commit from nevack/update-volume-slider into master

2021-01-07 02:06:39 -03:00

nevack commented

2021-01-07 00:53:59 -03:00

(Migrated from github.com)

Also fixes cut off Knob of Slider knob on Big Sur.

https://user-images.githubusercontent.com/8330119/103849168-182f7c80-50b5-11eb-8d5d-39c7bd3cf360.mov

Also fixes cut off Knob of Slider knob on Big Sur. https://user-images.githubusercontent.com/8330119/103849168-182f7c80-50b5-11eb-8d5d-39c7bd3cf360.mov

kode54 commented

2021-01-07 01:54:58 -03:00

(Migrated from github.com)

Does this also fix popping open when the window is at the bottom of the screen and therefore the point of origin for the popover should be its bottom, and thus pops upward instead of downward? I'll understand if that fix needs to be a separate PR.

nevack commented

2021-01-07 02:05:15 -03:00

(Migrated from github.com)

Does this also fix popping open when the window is at the bottom of the screen and therefore the point of origin for the popover should be its bottom, and thus pops upward instead of downward? I'll understand if that fix needs to be a separate PR.

Nope, but I want to fix it later. Another NSPopover can help I think, as system can override popover edge if it does not fit screen with preferred one.

> Does this also fix popping open when the window is at the bottom of the screen and therefore the point of origin for the popover should be its bottom, and thus pops upward instead of downward? I'll understand if that fix needs to be a separate PR. Nope, but I want to fix it later. Another NSPopover can help I think, as system can override popover edge if it does not fit screen with preferred one.

kode54 commented

2021-01-07 02:06:33 -03:00

(Migrated from github.com)

Right, thanks for this, it's great having another set of eyes looking at this.