chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Migrate to MASShortcut. #82

Merged
nevack merged 1 commit from nevack/shortcuts-refactor into master 2021-01-25 01:29:47 -03:00
Conversation 3 Commits 1 Files changed 24 +278 -3205
nevack commented 2021-01-25 00:09:31 -03:00 (Migrated from github.com)
Copy link

Removed NDHotKey code.
Added ability to restore default shortcuts.
Migrated old user-set shortcuts.

image

Removed NDHotKey code. Added ability to restore default shortcuts. Migrated old user-set shortcuts. ![image](https://user-images.githubusercontent.com/8330119/105656693-dfc0d880-5ed3-11eb-9b79-e2899561a4aa.png)
kode54 (Migrated from github.com) reviewed 2021-01-25 00:09:31 -03:00
nevack (Migrated from github.com) reviewed 2021-01-25 00:10:50 -03:00
Cog.xcodeproj/project.pbxproj
nevack (Migrated from github.com) commented 2021-01-25 00:10:49 -03:00
Copy link

Removed outdated search paths

Removed outdated search paths
nevack (Migrated from github.com) reviewed 2021-01-25 00:11:37 -03:00
Cog.xcodeproj/project.pbxproj
nevack (Migrated from github.com) commented 2021-01-25 00:11:37 -03:00
Copy link

I don't know yet a good way to include Shortcuts.h in Cog target.
@kode54 Can you help me?

I don't know yet a good way to include `Shortcuts.h` in Cog target. @kode54 Can you help me?
nevack (Migrated from github.com) reviewed 2021-01-25 00:12:26 -03:00
Preferences/Preferences/Preferences.xcodeproj/project.pbxproj
nevack (Migrated from github.com) commented 2021-01-25 00:12:26 -03:00
Copy link

Need to be removed...

Need to be removed...
nevack (Migrated from github.com) reviewed 2021-01-25 00:14:15 -03:00
Preferences/Preferences/Shortcuts.h
nevack (Migrated from github.com) commented 2021-01-25 00:14:15 -03:00
Copy link

I think this definitions will be compiled into static area twice, for each include.
Need a better way to workaround this.
extern leads to unsatisfied dynamic linkage error

I think this definitions will be compiled into static area twice, for each include. Need a better way to workaround this. `extern` leads to unsatisfied dynamic linkage error
nevack commented 2021-01-25 00:15:49 -03:00 (Migrated from github.com)
Copy link

Removed developer_team

Removed developer_team
kode54 (Migrated from github.com) reviewed 2021-01-25 00:18:25 -03:00
Cog.xcodeproj/project.pbxproj
kode54 (Migrated from github.com) commented 2021-01-25 00:18:24 -03:00
Copy link

When you use normal header maps in a project or sub-project, simply including the header file somewhere in the file tree for the project is enough to be able to:

#import <someheader.h>

This is what I do for the headers I include in each of the plugins.

When you use normal header maps in a project or sub-project, simply including the header file somewhere in the file tree for the project is enough to be able to: ``` #import <someheader.h> ``` This is what I do for the headers I include in each of the plugins.
kode54 (Migrated from github.com) reviewed 2021-01-25 00:28:04 -03:00
Preferences/Preferences/Shortcuts.h
kode54 (Migrated from github.com) commented 2021-01-25 00:28:04 -03:00
Copy link

You could also compile these constants into a static object file or library just so the strings are all sourced from the same binary instead of just the same source header. I'm not sure that's better or worse, either. Either way, they're going to be string included in every single source file that mentions the shortcuts, which shouldn't be too many, since it should only be the main application and the preferences pane.

You could also compile these constants into a static object file or library just so the strings are all sourced from the same binary instead of just the same source header. I'm not sure that's better or worse, either. Either way, they're going to be string included in every single source file that mentions the shortcuts, which shouldn't be too many, since it should only be the main application and the preferences pane.
kode54 (Migrated from github.com) reviewed 2021-01-25 00:28:31 -03:00
Cog.xcodeproj/project.pbxproj
kode54 (Migrated from github.com) commented 2021-01-25 00:28:31 -03:00
Copy link

Looks fine.

Looks fine.
nevack (Migrated from github.com) reviewed 2021-01-25 00:29:15 -03:00
Cog.xcodeproj/project.pbxproj
nevack (Migrated from github.com) commented 2021-01-25 00:29:15 -03:00
Copy link

File not found for me

`File not found` for me
kode54 (Migrated from github.com) reviewed 2021-01-25 00:32:32 -03:00
Cog.xcodeproj/project.pbxproj
kode54 (Migrated from github.com) commented 2021-01-25 00:32:32 -03:00
Copy link

Oh, crap. I don't know then. Somehow it works for the headers in each of the plugin projects. Maybe the project you're trying to use it in has header maps turned off? I know I had to do that for some frameworks due to weird issues like bonehead Xcode seeing a project header with the same name as a system header, and resolving the project header for:

#include <header.h>

Even when it's included that way within the identically named project header file, which is included elsewhere using:

#include "header.h"
Oh, crap. I don't know then. Somehow it works for the headers in each of the plugin projects. Maybe the project you're trying to use it in has header maps turned off? I know I had to do that for some frameworks due to weird issues like bonehead Xcode seeing a project header with the same name as a system header, and resolving the project header for: ``` #include <header.h> ``` Even when it's included that way within the identically named project header file, which is included elsewhere using: ``` #include "header.h" ```
nevack (Migrated from github.com) reviewed 2021-01-25 00:44:55 -03:00
Preferences/Preferences/Preferences.xcodeproj/project.pbxproj
nevack (Migrated from github.com) commented 2021-01-25 00:44:48 -03:00
Copy link

Moved Shortcuts.h to Cog target and made a direct reference in Preferences target

Moved `Shortcuts.h` to Cog target and made a direct reference in Preferences target
nevack commented 2021-01-25 00:48:53 -03:00 (Migrated from github.com)
Copy link

Resolved conflict

Resolved conflict
nevack commented 2021-01-25 01:20:24 -03:00 (Migrated from github.com)
Copy link

@kode54 ready for review now.

@kode54 ready for review now.
kode54 (Migrated from github.com) reviewed 2021-01-25 01:24:50 -03:00
Preferences/Preferences/Preferences.xcodeproj/project.pbxproj
kode54 (Migrated from github.com) commented 2021-01-25 01:24:50 -03:00
Copy link

That works.

That works.
Sign in to join this conversation.
Reviewers
No reviewers
kode54
Labels
Clear labels   
2230

   
2243

   
App version

   
Apple OS errata

Errata affecting old macOS releases

  
Apple SDK

   
bug

   
bugsnag

   
build

improve or fix project building

  
dlt

To be deleted

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chris/Cog#82
No description provided.
Delete branch "nevack/shortcuts-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?