chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions

Inhibit ThirdParty libraries warnings and refactor+modernize several classes #88

Merged
nevack merged 6 commits from nevack/inhibit-third-party-warnings into master 2021-01-30 22:46:39 -03:00
Conversation 6 Commits 6 Files changed 122 +1755 -1874
nevack commented 2021-01-30 20:18:46 -03:00 (Migrated from github.com)
Copy link

This got a little out of control, change is prerry big.

Copy & paste and Drag & Drop works as intended with Apple Music, Finder and FileTreeOutline

This got a little out of control, change is prerry big. Copy & paste and Drag & Drop works as intended with Apple Music, Finder and FileTreeOutline
kode54 (Migrated from github.com) reviewed 2021-01-30 20:18:46 -03:00
nevack commented 2021-01-30 20:19:40 -03:00 (Migrated from github.com)
Copy link

@kode54 First commit is more like mechanical change.

@kode54 First commit is more like mechanical change.
nevack commented 2021-01-30 20:22:52 -03:00 (Migrated from github.com)
Copy link

I think I'll update PlaylistEntry as a following change.
Also it will be good to have PlaylistEntry's index fields to be NSInteger/NSUInteger instead of int to conform to Apple's APIs

I think I'll update PlaylistEntry as a following change. Also it will be good to have PlaylistEntry's index fields to be NSInteger/NSUInteger instead of int to conform to Apple's APIs
kode54 commented 2021-01-30 20:42:14 -03:00 (Migrated from github.com)
Copy link

Yeah, that sounds good so far. The PlaylistEntry change sounds fine too.

Yeah, that sounds good so far. The PlaylistEntry change sounds fine too.
kode54 commented 2021-01-30 21:10:33 -03:00 (Migrated from github.com)
Copy link

Wait, this is ready now? Has anything changed since I last commented?

Wait, this is ready now? Has anything changed since I last commented?
nevack commented 2021-01-30 21:22:11 -03:00 (Migrated from github.com)
Copy link

Wait, this is ready now? Has anything changed since I last commented?

No changes. I just thought you could mind merging patch of this size in one PR.

> Wait, this is ready now? Has anything changed since I last commented? No changes. I just thought you could mind merging patch of this size in one PR.
kode54 commented 2021-01-30 22:46:33 -03:00 (Migrated from github.com)
Copy link

Looks okay, I'll have to build it later, though.

Looks okay, I'll have to build it later, though.
Sign in to join this conversation.
Reviewers
No reviewers
kode54
Labels
Clear labels   
2230

   
2243

   
App version

   
Apple OS errata

Errata affecting old macOS releases

  
Apple SDK

   
bug

   
bugsnag

   
build

improve or fix project building

  
dlt

To be deleted

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
2230
2243
App version
Apple OS errata
Apple SDK
bug
bugsnag
build
dlt
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chris/Cog#88
No description provided.
Delete branch "nevack/inhibit-third-party-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?