Play controls are not vertically aligned in buttons #96

New issue

Closed

opened 2021-02-07 19:59:54 -03:00 by kode54 · 5 comments

kode54 commented

2021-02-07 19:59:54 -03:00

(Migrated from github.com)

Describe the bug
The control icons are not aligned in the play buttons.

To Reproduce
Steps to reproduce the behavior:

Go to main window
Ensure play controls are added to toolbar

Expected behavior
Button icons should be vertically aligned.

Screenshots

Desktop (please complete the following information):

macOS version: 10.13.6
Cog version: Presumably latest

Additional context
User emailed me this screen shot.

**Describe the bug** The control icons are not aligned in the play buttons. **To Reproduce** Steps to reproduce the behavior: 1. Go to main window 2. Ensure play controls are added to toolbar **Expected behavior** Button icons should be vertically aligned. **Screenshots** ![Screen Shot 2021-02-07 at 21 44 58](https://user-images.githubusercontent.com/796316/107161987-2e9b5300-6955-11eb-8b98-d66e6c39dcd2.png) **Desktop (please complete the following information):** - macOS version: 10.13.6 - Cog version: Presumably latest **Additional context** User emailed me this screen shot.

nevack commented

2021-02-08 15:08:59 -03:00

(Migrated from github.com)

Hm, interesting. I think we can import backported SF Symbols 2.1 and use them.

kode54 commented

2021-02-08 20:01:10 -03:00

(Migrated from github.com)

Only if we convert them to .PDFs using something. SVG isn't supported by anything older than Big Sur.

nevack commented

2021-02-08 20:54:21 -03:00

(Migrated from github.com)

I know, but these symbols are formatted in special way, so I suppose they are handled by build system, like convert them to pngs/pdfs if target is below BigSur.

Example

I know, but these symbols are formatted in special way, so I suppose they are handled by build system, like convert them to pngs/pdfs if target is below BigSur. Example ![image](https://user-images.githubusercontent.com/8330119/107296258-12e19b00-6a82-11eb-898b-fda61006ed05.png) ![image](https://user-images.githubusercontent.com/8330119/107296278-1a08a900-6a82-11eb-93d0-fb82d4be3400.png)

kode54 commented

2021-02-08 21:06:03 -03:00

(Migrated from github.com)

We've tried embedding symbols from SF Symbols the automatic way. The format it chooses is SVG, which, again, doesn't work below Big Sur.

E: #55 is the relevant issue.

We've tried embedding symbols from SF Symbols the automatic way. The format it chooses is SVG, which, again, doesn't work below Big Sur. E: #55 is the relevant issue.

nevack commented

2021-02-08 21:30:02 -03:00

(Migrated from github.com)

Oh, that's bad