chris/Cog
2
1
Fork 0
Code Issues 65 Pull requests Projects Releases Packages Wiki Activity Actions 1

Rubberband: Disable by default correctly

Browse source 
The attempt to disable it by default only for new installs failed, as
changing the default after restarting with consent achieved, resulted in
the value changing as well, as is the way of changing defaults if the
user has never changed them.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
This commit is contained in:
Christopher Snowhill 2025-06-20 19:33:36 -07:00
parent 3b14269e12
commit e8775e17b0
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Application/PlaybackController.m
View file

@ -130,7 +130,7 @@ NSString *CogPlaybackDidStopNotificiation = @"CogPlaybackDidStopNotificiation";
@"enableHrtf": @(NO), @"enableHrtf": @(NO),
@"enableHeadTracking": @(NO), @"enableHeadTracking": @(NO),
@"enableHDCD": @(NO), @"enableHDCD": @(NO),
/*@"rubberbandEngine": @"faster",*/ @"rubberbandEngine": @"disabled",
@"rubberbandTransients": @"crisp", @"rubberbandTransients": @"crisp",
@"rubberbandDetector": @"compound", @"rubberbandDetector": @"compound",
@"rubberbandPhase": @"laminar", @"rubberbandPhase": @"laminar",

4
Window/MainWindow.m
View file

@ -19,8 +19,6 @@
void showSentryConsent(NSWindow *window) { void showSentryConsent(NSWindow *window) {
BOOL askedConsent = [[NSUserDefaults standardUserDefaults] boolForKey:@"sentryAskedConsent"]; BOOL askedConsent = [[NSUserDefaults standardUserDefaults] boolForKey:@"sentryAskedConsent"];
if(!askedConsent) { if(!askedConsent) {
[[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"rubberbandEngine": @"disabled" }];
[window orderFront:window]; [window orderFront:window];
NSAlert *alert = [[NSAlert alloc] init]; NSAlert *alert = [[NSAlert alloc] init];
@ -36,8 +34,6 @@ void showSentryConsent(NSWindow *window) {
}]; }];
[[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"sentryAskedConsent"]; [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"sentryAskedConsent"];
} else {
[[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"rubberbandEngine": @"faster" }];
} }
} }