Update vgmstream to r1896

faxx1080 commented

2024-01-20 14:04:33 -03:00

(Migrated from github.com)

Imports changes from r1896 of vgmstream.

I manually went through each file to find cases where the headers change slightly. I've tested on Zelda, Sonic, Metroid but not too many games.

Imports changes from r1896 of vgmstream. I manually went through each file to find cases where the headers change slightly. I've tested on Zelda, Sonic, Metroid but not too many games.

kode54 commented

2024-01-20 18:56:34 -03:00

(Migrated from github.com)

I mean, sure, I could import this, but I won't have anything to produce new builds with.

faxx1080 commented

2024-01-21 10:50:29 -03:00

(Migrated from github.com)

I'm not sure what you mean by that?

kode54 commented

2024-01-21 17:14:23 -03:00

(Migrated from github.com)

Also, why did you do this manually? My regular process would have been to format-patch the upstream repository and apply the patches, modifying the code as necessary where the patches fail.

faxx1080 commented

2024-01-21 20:04:56 -03:00

(Migrated from github.com)

Ahh, because I was still unfamiliar with the macOS edits to vgmstream; and of the build process. The patches looked old (they had dates of 2018) and being used to repos with lots more aged code, I wasn't sure it would work.

That and I was personally impatient myself and wanted to challenge myself to "fix things myself" so I could get Sonic Superstars HCA files working. Once I did, thought it'd be a good idea to contribute back to upstream.

Ahh, because I was still unfamiliar with the macOS edits to vgmstream; and of the build process. The patches looked old (they had dates of 2018) and being used to repos with lots more aged code, I wasn't sure it would work. That and I was personally impatient myself and wanted to challenge myself to "fix things myself" so I could get Sonic Superstars HCA files working. Once I did, thought it'd be a good idea to contribute back to upstream.

kode54 commented

2024-01-21 23:23:20 -03:00

(Migrated from github.com)

I have updated past the snapshot you updated to, but in a branch. It would be most helpful if you could update the libvgmstream project file to include the new files, and reference the renames contained within the commit. There is also a new directory, src/coding/libs that needs its two files added to the project. I will merge the result once tests complete.

However, I don't have a modern Mac to build for the App Store, so there won't be any binary updates for a few months, at least.

I have updated past the snapshot you updated to, but in a branch. It would be most helpful if you could update the libvgmstream project file to include the new files, and reference the renames contained within the commit. There is also a new directory, `src/coding/libs` that needs its two files added to the project. I will merge the result once tests complete. However, I don't have a modern Mac to build for the App Store, so there won't be any binary updates for a few months, at least.

kode54 commented

2024-01-24 04:26:00 -03:00

(Migrated from github.com)

By the way, for the future reference, format-patch generation should work from the last merged commit hash, which is on the long form version tag that I include with each update to vgmstream.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Update vgmstream to r1896 #390

Pull request closed